Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add C Builder Index to the channel name to make it unique in case of … #271

Merged
merged 1 commit into from
Jul 15, 2022
Merged

Add C Builder Index to the channel name to make it unique in case of … #271

merged 1 commit into from
Jul 15, 2022

Conversation

joyeshmishra
Copy link
Contributor

…duplicate c process models

Issue Number:

Objective of pull request:

Pull request checklist

Your PR fulfills the following requirements:

  • Issue created that explains the change and why it's needed
  • Tests are part of the PR (for bug fixes / features)
  • Docs reviewed and added / updated if needed (for bug fixes / features)
  • PR conforms to Coding Conventions
  • PR applys BSD 3-clause or LGPL2.1+ Licenses to all code files
  • Lint (flakeheaven lint src/lava tests/) and (bandit -r src/lava/.) pass locally
  • Build tests (pytest) passes locally

Pull request type

Please check your PR type:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation changes
  • Other (please describe):

What is the current behavior?

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Supplemental information

GaboFGuerra
GaboFGuerra approved these changes Jul 15, 2022
View reviewed changes
Copy link
Contributor

@GaboFGuerra GaboFGuerra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Joyesh, looks good!

bamsumit
bamsumit approved these changes Jul 15, 2022
View reviewed changes
Copy link
Contributor

@bamsumit bamsumit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@joyeshmishra joyeshmishra merged commit af84234 into main Jul 15, 2022
@joyeshmishra joyeshmishra deleted the channel_disambiguation branch July 15, 2022 16:19
monkin77 pushed a commit to monkin77/thesis-lava that referenced this pull request Jul 12, 2024
@joyeshmishra
Add C Builder Index to the channel name to make it unique in case of …
d9fce28 
…duplicate c process models (lava-nc#271)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bamsumit bamsumit bamsumit approved these changes

@GaboFGuerra GaboFGuerra GaboFGuerra approved these changes

@mgkwill mgkwill Awaiting requested review from mgkwill

@srrisbud srrisbud Awaiting requested review from srrisbud

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joyeshmishra @bamsumit @GaboFGuerra